Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Max connections error #123

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Max connections error #123

merged 2 commits into from
Jul 16, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 16, 2021

🎉 New feature

Summary

Return a new error code and message when a websocket connection hits the max_connections threshold.

Test it

I tested this using subt:

ign launch -v 4 cloudsim_sim.ign worldName:=simple_cave_01 circuit:=cave websocketMaxConnections:=0

The use the web-app visualizer to attempt a connection.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Nate Koenig added 2 commits July 16, 2021 13:08
Output a better error code for max connections
d3888bc 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Documentation
5edaf3d 
Signed-off-by: Nate Koenig <nate@openrobotics.org>
@nkoenig nkoenig requested a review from german-e-mas July 16, 2021 20:14
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jul 16, 2021
german-e-mas
german-e-mas approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@german-e-mas german-e-mas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nkoenig nkoenig merged commit 605614a into ign-launch3 Jul 16, 2021
@nkoenig nkoenig deleted the max_connections_error branch July 16, 2021 20:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@german-e-mas german-e-mas german-e-mas approved these changes

Assignees
No one assigned
Labels
🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @german-e-mas