Throttle websocket #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @nkoenig . I'll let you know how this goes. Should we pay attention to the unsuccessful checks? |
german-e-mas
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
Thanks @nkoenig ! LGTM. I just left a comment about a Bitbucket reference.
I changed the rate to 1 Hz locally and it worked well.
This change also includes the parseFromArray change, I can confirm it's working as intended as well.
Signed-off-by: Nate Koenig <nate@openrobotics.org>
nkoenig
force-pushed
the
throttle_websocket
branch
from
99d9b14 to
45aacde
Compare
Signed-off-by: Nate Koenig <nate@openrobotics.org>
nkoenig
force-pushed
the
throttle_websocket
branch
from
ceb59db to
14c70bc
Compare
|
Build finished. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to throttle the websocket server publication rate.