Fix windows warnings #199
Merged
Fix windows warnings #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-launch6 #199 +/- ##
===========================================
Coverage 56.90% 56.90%
===========================================
Files 3 3
Lines 413 413
===========================================
Hits 235 235
Misses 178 178 ☔ View full report in Codecov by Sentry. |
ahcorde
approved these changes
Sep 14, 2022
|
@nkoenig to get back to this |
|
@osrf-jenkins retest this please |
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
|
This doesn't fix all of the windows warnings, but it has reduced them. I think it's okay to get this in. |
ahcorde
approved these changes
Feb 14, 2024
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Crola1702
pushed a commit
that referenced
this pull request
May 23, 2024
* Fix windows warnings Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows warnings Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Added string include Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Crola1702
added a commit
that referenced
this pull request
May 24, 2024
* Fix windows warnings (#199) * Fix windows warnings Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix more windows warnings Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Added string include Signed-off-by: Nate Koenig <natekoenig@gmail.com> --------- Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Nate Koenig <nate@openrobotics.org> * Include vector Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> --------- Signed-off-by: Nate Koenig <nate@openrobotics.org> Signed-off-by: Nate Koenig <natekoenig@gmail.com> Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> Co-authored-by: Nate Koenig <natekoenig@gmail.com> Co-authored-by: Nate Koenig <nate@openrobotics.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.