Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Disable failing windows tests #255

Merged
merged 5 commits into from
May 21, 2024
Merged

Disable failing windows tests #255

merged 5 commits into from
May 21, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 16, 2024

🦟 Bug fix

Fixes #203

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey
Disable ManagerTest.RunLs test on windows
2b383b4 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from nkoenig as a code owner April 16, 2024 22:30
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 16, 2024
azeey added 4 commits April 17, 2024 12:01
@azeey
Add dependency on ign-utils
ed7b2bb 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Use Pathname to determine if path is absolute
a2fae72 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Disable ign_TEST on windows, disable ManagerTest.RunEnvPre because it…
52991de 
… timesout

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
Disable one more test on windows
8e6b18e 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey mentioned this pull request Apr 25, 2024
Closed
8 tasks
@azeey
Copy link
Contributor Author

azeey commented Apr 25, 2024

Failing windows tests have been disabled. CI is still red because of warnings, which should be handled in separate PR.

@azeey azeey changed the title Disable ManagerTest.RunLs test on windows Disable failing windows tests Apr 25, 2024
@azeey
Copy link
Contributor Author

azeey commented May 6, 2024

friendly ping @nkoenig

@azeey azeey merged commit 6459d02 into gazebosim:ign-launch5 May 21, 2024
9 of 10 checks passed
@azeey azeey deleted the diable_manager_ls branch May 21, 2024 22:47
@Blast545 Blast545 mentioned this pull request May 27, 2024
Merged
8 tasks
@azeey azeey mentioned this pull request May 28, 2024
Closed
8 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @Blast545