Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable ubuntu noble on github actions, require cmake 3.22.1 #272

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 16, 2024

🎉 New feature

Summary

Adds Ubuntu Noble CI on github actions, and update min required cmake version to 3.22.1

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from nkoenig as a code owner August 16, 2024 22:46
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.49%. Comparing base (2cb58a1) to head (77a3b2c).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
+ Coverage   57.80%   58.49%   +0.68%     
==========================================
  Files           4        4              
  Lines         429      424       -5     
==========================================
  Hits          248      248              
+ Misses        181      176       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey added the beta Targeting beta release of upcoming collection label Aug 17, 2024
@azeey azeey merged commit 5a72f0f into main Aug 17, 2024
12 checks passed
@azeey azeey deleted the iche033/ionic_cmake branch August 17, 2024 00:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
beta Targeting beta release of upcoming collection 🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants