Added <max_connections> to the websocket server

examples/websocket.ign

@@ -10,6 +10,10 @@
     <authorization_key>auth_key</authorization_key>
     <admin_authorization_key>admin_key</admin_authorization_key>
 
+    <!-- The maximum number of allowed connections. If this element is not
+         defined or negative, then a limit is not enforced. -->
+    <max_connections>10</max_connections>
+
     <!-- SSL configuration -->
     <!-- Specify the path to both the certificate and private key. -->
     <!-- Sample self-signed SSL certifacts are located in the

plugins/websocket_server/WebsocketServer.cc

@@ -66,6 +66,19 @@ int rootCallback(struct lws *_wsi,
   // std::lock_guard<std::mutex> mainLock(self->mutex);
   switch (_reason)
   {
+    // Filter network connections.
+    case LWS_CALLBACK_FILTER_NETWORK_CONNECTION:
+      // Prevent too many connections.
+      if (self->maxConnections >= 0 &&
+          self->connections.size()+1 > self->maxConnections)
+      {
+        ignerr << "Skipping new connection, limit of "
+          << self->maxConnections << " has been reached\n";
+        // Return non-zero to close the connection.
+        return -1;
+      }
+      break;
+
     // Open connections.
     case LWS_CALLBACK_ESTABLISHED:
       igndbg << "LWS_CALLBACK_ESTABLISHED\n";
@@ -214,6 +227,23 @@ bool WebsocketServer::Load(const tinyxml2::XMLElement *_elem)
   }
   igndbg << "Using port[" << port << "]\n";
 
+  // Get the maximum connection count, if present.
+  elem = _elem->FirstChildElement("max_connections");
+  if (elem)
+  {
+    try
+    {
+      this->maxConnections = std::stoi(elem->GetText());
+    }
+    catch (...)
+    {
+      ignerr << "Failed to convert port[" << elem->GetText() << "] to integer."
+        << std::endl;
+    }
+    igndbg << "Using maximum connetion count of "
+      << this->maxConnections << std::endl;
+  }
+
   std::string sslCertFile = "";
   std::string sslPrivateKeyFile = "";
   elem = _elem->FirstChildElement("ssl");
@@ -374,6 +404,9 @@ void WebsocketServer::OnConnect(int _socketId)
 //////////////////////////////////////////////////
 void WebsocketServer::OnDisconnect(int _socketId)
 {
+  if (this->connections.find(_socketId) == this->connections.end())
+    return;
+
   this->connections.erase(_socketId);
 
   // Somewhat slow operation.
@@ -393,6 +426,10 @@ void WebsocketServer::OnDisconnect(int _socketId)
 //////////////////////////////////////////////////
 void WebsocketServer::OnMessage(int _socketId, const std::string &_msg)
 {
+  // Skip invalid sockets
+  if (this->connections.find(_socketId) == this->connections.end())
+    return;
+
   // Frame: operation,topic,type,payload
   std::vector<std::string> frameParts = common::split(_msg, ",");
 

plugins/websocket_server/WebsocketServer.hh

@@ -150,7 +150,13 @@ namespace ignition
                    const size_t _size,
                    const ignition::transport::MessageInfo &_info);
 
+      /// \brief Callback that is triggered when a new connection is
+      /// established.
+      /// \param[in] _socketId ID of the socket.
       public: void OnConnect(int _socketId);
+
+      /// \brief Callback that is triggered when a connection ended.
+      /// \param[in] _socketId ID of the socket.
       public: void OnDisconnect(int _socketId);
 
       public: void OnMessage(int _socketId, const std::string &_msg);
@@ -201,6 +207,10 @@ namespace ignition
       /// run loop.
       public: int messageCount{0};
 
+      /// \brief The maximum number of connections. A negative number
+      /// indicates no limit.
+      public: int maxConnections{-1};
+
       /// \brief Time of last publication for each subscribed topic. The key
       /// is the topic name and the value the time of last publication.
       /// \sa publishPeriod.