Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix codecheck #67

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Fix codecheck #67

merged 1 commit into from
Oct 15, 2020

Conversation

chapulina
Copy link
Contributor

These slipped through #57, probably because GitHub actions didn't run for a fork (which is addressed in #66 ).

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner October 14, 2020 23:24
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Oct 14, 2020
@chapulina chapulina requested a review from mjcarroll October 14, 2020 23:24
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #67 into ign-launch1 will increase coverage by 0.86%.
The diff coverage is 68.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-launch1      #67      +/-   ##
===============================================
+ Coverage        28.15%   29.01%   +0.86%     
===============================================
  Files                3        3              
  Lines              721      734      +13     
===============================================
+ Hits               203      213      +10     
- Misses             518      521       +3     
Impacted Files Coverage Δ
src/Manager.cc 53.16% <68.42%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f5192...b8c0e84. Read the comment docs.

@chapulina chapulina merged commit eb93a00 into ign-launch1 Oct 15, 2020
@chapulina chapulina deleted the chapulina/codecheck branch October 15, 2020 02:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants