-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Interval class #388
Add Interval class #388
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@chapulina PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to add this a Python interfaces ? or if you don't have time please open an issue.
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 99.64% 99.72% +0.08%
==========================================
Files 65 66 +1
Lines 6115 6189 +74
==========================================
+ Hits 6093 6172 +79
+ Misses 22 17 -5
Continue to review full report at Codecov.
|
@ahcorde I'll open an issue once we merge this PR. I promise I'll get back and implement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the tests, documentation and example. I just have minor comments, but nothing blocking.
Python interfaces will be added on follow up PRs.
|
||
namespace detail { | ||
template<typename T> | ||
const Interval<T> gUnboundedInterval = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
🎉 New feature
Summary
Split from #387. This PR introduces an
Interval
class to represent scalar, real intervals.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.