Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Polynomial3 class #393

Merged
merged 9 commits into from
Mar 23, 2022
Merged

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Mar 18, 2022

🎉 New feature

Summary

Split from #387. This PR introduces a Polynomial3 class to cubic polynomials with real coefficients.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic added the MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv label Mar 18, 2022
@hidmic hidmic requested a review from scpeters as a code owner March 18, 2022 22:26
@hidmic
Copy link
Contributor Author

hidmic commented Mar 18, 2022

@chapulina PTAL!

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 18, 2022
@chapulina chapulina self-requested a review March 18, 2022 22:36
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #393 (4d8d4b1) into main (289dbc3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   99.72%   99.73%           
=======================================
  Files          67       68    +1     
  Lines        6219     6314   +95     
=======================================
+ Hits         6202     6297   +95     
  Misses         17       17           
Impacted Files Coverage Δ
include/ignition/math/Polynomial3.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289dbc3...4d8d4b1. Read the comment docs.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic added 4 commits March 22, 2022 17:35
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic mentioned this pull request Mar 23, 2022
39 tasks
@hidmic hidmic requested a review from chapulina March 23, 2022 19:47
hidmic added 2 commits March 23, 2022 18:31
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the add-polynomial3-class branch from 79d493c to 4d8d4b1 Compare March 23, 2022 21:31
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating, LGTM!

@chapulina chapulina merged commit b1cb6bb into gazebosim:main Mar 23, 2022
@hidmic hidmic deleted the add-polynomial3-class branch March 24, 2022 16:48
ahcorde pushed a commit that referenced this pull request Jul 4, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
chapulina added a commit that referenced this pull request Jul 8, 2022
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🌱 garden Ignition Garden MBARI-LRAUV Sponsored by MBARI-LRAUV project: https://github.com/osrf/lrauv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants