Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Particle emitter message #127

Merged
merged 5 commits into from
Jan 29, 2021
Merged

Particle emitter message #127

merged 5 commits into from
Jan 29, 2021

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Jan 20, 2021

Stores all attributes of a particle emitter.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Jan 20, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have some questions because I haven't used particles before.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #127 (2494142) into ign-msgs6 (da885b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-msgs6     #127   +/-   ##
==========================================
  Coverage      84.59%   84.59%           
==========================================
  Files              7        7           
  Lines            818      818           
==========================================
  Hits             692      692           
  Misses           126      126           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da885b4...2494142. Read the comment docs.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero merged commit 69a7104 into ign-msgs6 Jan 29, 2021
@caguero caguero deleted the particle_emiter branch January 29, 2021 23:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants