Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

scene.proto: add shadow_caster_material_name #179

Merged
merged 5 commits into from
Sep 17, 2021
Merged

scene.proto: add shadow_caster_material_name #179

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc9bfba
scene.proto: add shadow_caster_material_name
scpeters Sep 8, 2021
0187394
Merge branch 'main' into scene_shadow_caster_material_name
scpeters Sep 15, 2021
b118c49
Merge branch 'main' into scene_shadow_caster_material_name
chapulina Sep 16, 2021
6addaa4
Add Script sub-message with uri, material_name
scpeters Sep 17, 2021
e418f2f
Use Material.Script instead of duplicate type
scpeters Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/ignition/msgs/scene.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,7 @@ message Scene

/// \brief Show/hide world origin indicator.
bool origin_visual = 12;

/// \brief Name of shadow caster material.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// \brief Name of shadow caster material.
/// \brief Shadow caster material script.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied in scpeters@e418f2f

string shadow_caster_material_name = 13;
}