Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add EntityPlugin_V msg #261

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Add EntityPlugin_V msg #261

merged 1 commit into from
Jun 23, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 7, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🎉 New feature

Summary

Adds an EntityPlugin_V.proto msg to store plugins / systems for an Entity.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from caguero as a code owner June 7, 2022 23:33
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #261 (fe0a9ec) into ign-msgs8 (7e1b8d4) will increase coverage by 69.93%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           ign-msgs8     #261       +/-   ##
==============================================
+ Coverage      15.44%   85.38%   +69.93%     
==============================================
  Files            382        9      -373     
  Lines          65279      951    -64328     
==============================================
- Hits           10083      812     -9271     
+ Misses         55196      139    -55057     
Impacted Files Coverage Δ
include/ignition/msgs/cylindergeom.pb.cc
include/ignition/msgs/world_control.pb.h
include/ignition/msgs/axis.pb.h
include/ignition/msgs/pose_v.pb.h
include/ignition/msgs/empty.pb.h
include/ignition/msgs/response.pb.cc
include/ignition/msgs/fluid_pressure.pb.h
include/ignition/msgs/user_cmd_stats.pb.h
include/ignition/msgs/version.pb.cc
include/ignition/msgs/gui_camera.pb.h
... and 381 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e1b8d4...fe0a9ec. Read the comment docs.

@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jun 8, 2022
@chapulina chapulina merged commit d426ba7 into ign-msgs8 Jun 23, 2022
@chapulina chapulina deleted the entity_plugin_v branch June 23, 2022 03:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏯 fortress Ignition Fortress OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants