Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove ignition #367

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Remove ignition #367

merged 5 commits into from
Aug 11, 2023

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jul 27, 2023

🎉 New feature

Removes ignition

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig nkoenig requested a review from caguero as a code owner July 27, 2023 12:51
@nkoenig nkoenig marked this pull request as draft July 27, 2023 12:51
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #367 (11cc58d) into main (241b06e) will increase coverage by 1.22%.
The diff coverage is 100.00%.

❗ Current head 11cc58d differs from pull request most recent head 92cf0b0. Consider uploading reports for the commit 92cf0b0 to get more accurate results

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   95.71%   96.93%   +1.22%     
==========================================
  Files           9        9              
  Lines        1073     1045      -28     
==========================================
- Hits         1027     1013      -14     
+ Misses         46       32      -14     
Files Changed Coverage Δ
src/Generator.cc 93.50% <ø> (ø)
include/gz/msgs/Factory.hh 100.00% <100.00%> (+28.57%) ⬆️
src/Factory.cc 89.88% <100.00%> (+7.64%) ⬆️

nkoenig added 2 commits July 27, 2023 21:38
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@mjcarroll
Copy link
Contributor

I think this one we can actually target at harmonic if we don't do the version bumps. msgs is already being bumped for harmonic, though.

Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Copy link
Contributor Author

nkoenig commented Aug 2, 2023

I think this one we can actually target at harmonic if we don't do the version bumps. msgs is already being bumped for harmonic, though.

There are no API/ABI breaking changes, but there is a behavior change. gz-msgs9 will output deprecation warnings, for example.

@nkoenig nkoenig marked this pull request as ready for review August 2, 2023 12:11
@mjcarroll
Copy link
Contributor

Focal CI isn't going to run here (removed from this branch), so this is good to go.

@mjcarroll mjcarroll merged commit 47df55c into main Aug 11, 2023
@mjcarroll mjcarroll deleted the nkoenig/remove-ign branch August 11, 2023 12:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants