Miscellaneous cleanups of protobuf generator plugin #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## gz-msgs10 #405 +/- ##
=============================================
+ Coverage 97.26% 97.67% +0.40%
=============================================
Files 27 27
Lines 1172 1163 -9
=============================================
- Hits 1140 1136 -4
+ Misses 32 27 -5
|
ahcorde
approved these changes
Oct 30, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unused code and variables and fixes some style nits.