Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use relative install path for gz tool data #141

Closed
wants to merge 1 commit into from

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Apr 4, 2024

🦟 Bug fix

Summary

Fixes an error when building https://github.com/gazebo-release/gz_plugin_vendor/ in the ROS buildfarm.

Similar to gazebosim/gz-tools#137

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from ahcorde as a code owner April 4, 2024 17:33
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (faadc0d) to head (95b8eeb).
Report is 1 commits behind head on gz-plugin2.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-plugin2     #141   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey
Copy link
Contributor Author

azeey commented Apr 4, 2024

Duplicate of #140.

@azeey azeey closed this Apr 4, 2024
@azeey azeey deleted the azeey/rel_paths branch April 4, 2024 18:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant