Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add Windows installation #192

Closed
wants to merge 1 commit into from
Closed

Add Windows installation #192

wants to merge 1 commit into from

Conversation

mabelzhang
Copy link
Contributor

Partially addresses gazebosim/docs#117

Builds with warnings.

Only OGRE supported for now.

@mabelzhang
add windows installation
90d0717 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang requested a review from iche033 as a code owner December 24, 2020 14:04
@mabelzhang mabelzhang added the Windows Windows support label Dec 24, 2020
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Dec 24, 2020
@codecov
Copy link

codecov bot commented Dec 24, 2020 •
edited
Loading

Codecov Report

Merging #192 (90d0717) into ign-rendering4 (2c85d92) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #192      +/-   ##
==================================================
- Coverage           52.58%   52.57%   -0.01%     
==================================================
  Files                 143      143              
  Lines               13337    13337              
==================================================
- Hits                 7013     7012       -1     
- Misses               6324     6325       +1
Impacted Files Coverage Δ
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c85d92...90d0717. Read the comment docs.

@chapulina chapulina added the documentation Improvements or additions to documentation label Dec 28, 2020
JShep1
JShep1 reviewed Dec 29, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, few nitpicks. Also, perhaps we should have a small note indicating that ogre2 is not yet supported in Windows?

@mabelzhang mabelzhang mentioned this pull request Jan 14, 2021
Merged
@mabelzhang
Copy link
Contributor Author

Closing in favor of #196, where comments above have been addressed.

@mabelzhang mabelzhang closed this Jan 14, 2021
@mabelzhang mabelzhang deleted the mabelzhang/windows_install branch January 14, 2021 09:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JShep1 JShep1 JShep1 left review comments

@chapulina chapulina Awaiting requested review from chapulina

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation 🔮 dome Ignition Dome Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabelzhang @JShep1 @chapulina