-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add new functions for manipulating the environment #114
Conversation
This adds functions for using collections with the environment. It allows for conveniently retreiving and setting the environment variables via a map, rather than individually. This also adds a clearenv and printenv for completeness. Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## gz-utils2 #114 +/- ##
==============================================
- Coverage 91.97% 79.67% -12.31%
==============================================
Files 6 8 +2
Lines 137 364 +227
==============================================
+ Hits 126 290 +164
- Misses 11 74 +63
|
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
faabbe0
to
65f81d7
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
f270fd2
to
55451cc
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
8b2a7d4
to
c0f0542
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
239ecb6
to
1756d83
Compare
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Is the idea to eventually deprecate the env functions in gz-common and use these instead? |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
The gz-common ones are now just forwarding to the other env functions here. I added them because we have packages that we want env functionality in that don't depend on gz-common (eg sdformat). |
A couple of tests are failing on windows. |
Neat. So what this was is that |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This adds functions for using collections with the environment. It allows for conveniently retreiving and setting the environment variables via a map, rather than individually.
This also adds a clearenv and printenv for completeness.