Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CXX_STANDARD in core library #77

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes .pc file (see osrf/homebrew-simulation#2016 (comment))

Summary

We used to use a c++standard cmake variable, but recently changed to using CMAKE_CXX_STANDARD but hadn't updated the CXX_STANDARD argument to gz_create_core_library. This caused a pkg-config compilation test to fail during a brew bottle build, but it should be fixed now.

Confirm by checking for a -std=c++17 flag in the output of pkg-config --cflags gz-utils2.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from chapulina August 30, 2022 20:30
@scpeters scpeters requested a review from azeey as a code owner August 30, 2022 20:30
@scpeters scpeters added the bug Something isn't working label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #77 (1cf5737) into gz-utils2 (d8d6c91) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           gz-utils2      #77   +/-   ##
==========================================
  Coverage      91.97%   91.97%           
==========================================
  Files              6        6           
  Lines            137      137           
==========================================
  Hits             126      126           
  Misses            11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit 855a64b into gz-utils2 Aug 30, 2022
@scpeters scpeters deleted the scpeters/fix_cxx_standard branch August 30, 2022 20:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants