Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes
.pc
file (see osrf/homebrew-simulation#2016 (comment))Summary
We used to use a
c++standard
cmake variable, but recently changed to usingCMAKE_CXX_STANDARD
but hadn't updated theCXX_STANDARD
argument togz_create_core_library
. This caused apkg-config
compilation test to fail during a brew bottle build, but it should be fixed now.Confirm by checking for a
-std=c++17
flag in the output ofpkg-config --cflags gz-utils2
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.