Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing config.hh include to gz headers #90

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes some gz headers

Summary

The gz/utils/*.hh headers on ign-utils1 that use the ignition namespace need to include gz/utils/config.hh to get the gz namespace. I found this while trying to use gz::utils::ImplPtr in sdformat12:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner December 15, 2022 00:55
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #90 (5a2174e) into ign-utils1 (64765dc) will not change coverage.
The diff coverage is n/a.

❗ Current head 5a2174e differs from pull request most recent head dfcc3d4. Consider uploading reports for the commit dfcc3d4 to get more accurate results

@@             Coverage Diff             @@
##           ign-utils1      #90   +/-   ##
===========================================
  Coverage       91.97%   91.97%           
===========================================
  Files               6        6           
  Lines             137      137           
===========================================
  Hits              126      126           
  Misses             11       11           
Impacted Files Coverage Δ
include/gz/utils/ImplPtr.hh 100.00% <ø> (ø)
include/gz/utils/NeverDestroyed.hh 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters scpeters merged commit f10af7e into ign-utils1 Dec 15, 2022
@scpeters scpeters deleted the scpeters/missing_config_headers branch December 15, 2022 18:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants