-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Launch file for running gz_bridge #530
Conversation
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@@ -0,0 +1,110 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove first empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in ff3149b
declare_container_name_cmd = DeclareLaunchArgument( | ||
'container_name', | ||
default_value='ros_gz_container', | ||
description='the name of container that nodes will load in if use composition', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description='the name of container that nodes will load in if use composition', | |
description='Name of container that nodes will load in if use composition', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in ff3149b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
declare_container_name_cmd = DeclareLaunchArgument( | ||
'container_name', | ||
default_value='ros_gz_container', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: The default here should match what we name container in #528
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ff3149b.
🎉 New feature
Part of #544
Summary
This patch allows to run the
ros_gz
bridge as an executable or as a composable node.How to test it?
Use the provided
ros_gz_bridge.launch.py
(modifyconfig_file
accordingly) to run the bridge as an executableVerify that you see the
/ros_chatter
topic:And confirm that no container has been created:
Now
CTRL-C
the bridge and try the composable version:Verify that you see the
/ros_chatter
topic:And confirm that a container has been created:
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.