-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add LogicalCameraImage support #698
Merged
ahcorde
merged 11 commits into
gazebosim:ros2
from
Dyst-0:add-logical-camera-image-support
Feb 24, 2025
Merged
Add LogicalCameraImage support #698
ahcorde
merged 11 commits into
gazebosim:ros2
from
Dyst-0:add-logical-camera-image-support
Feb 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apologies for the commit mess. |
46527fe
to
1472604
Compare
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Implemented convert_ros_to_gz and convert_gz_to_ros for LogicalCameraImage. Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Documented support for bridging LogicalCameraImage Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
auto* --> auto * Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
f94ab55
to
f8484e3
Compare
ahcorde
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected member name to "model" instead of "models" Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
95fa986
to
bb83151
Compare
removed trailing whitespace Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
changed int to size_t to avoid sign-compare warning Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
ahcorde
approved these changes
Feb 24, 2025
@ahcorde can this be backported to jazzy? |
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com> (cherry picked from commit 16fbab4)
9 tasks
ahcorde
pushed a commit
that referenced
this pull request
Feb 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #697
Summary
ros_gz_bridge
now supportsgz.msgs.LogicalCamera image
<->ros_gz_interfaces.msg.LogicalCameraImage
.Test it
Test gz to ros conversion
1: Run
parameter_bridge
for/logical_camera
between gz and ros2: In a new terminal, run
3: In another terminal, publish the message from gz
In the terminal listening to
/logical_camera
, the output should beTest ros to gz conversion
1: Run
parameter_bridge
for/logical_camera
between gz and ros2: In another terminal, listen to the gz topic
/logical_camera
3: Publish the ros message
In the terminal listening to
/logical_camera
, the output should beChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.