Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

workflows/ci.yml fix push branch regex #1445

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes triggering of GitHub workflows on branches with double-digit major version.

Summary

Ubuntu workflows for branches with a double digit major version number haven't been running for a while (6 months since the last sdf14 build). I believe this is due to the regex pattern used to match our release branches.

The current pattern matches the following:
"sdf", "sdf0", "sdf1", ..., "sdf8", "sdf9"
of which "sdf" is incorrect, and only "sdf9"
is currently supported. This updates the pattern
to match single digits "sdf1" - "sdf9" and double
digits "sdf10" to "sdf99".

I don't think we can test this without merging it?

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The current pattern matches the following:
"sdf", "sdf0", "sdf1", ..., "sdf8", "sdf9"
of which "sdf" is incorrect, and only "sdf9"
is currently supported. This updates the pattern
to match single digits "sdf1" - "sdf9" and double
digits "sdf10" to "sdf99".

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner June 27, 2024 18:18
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 27, 2024
@scpeters
Copy link
Member Author

the Noble workflow failure is due to gazebo-tooling/action-gz-ci#76

@scpeters scpeters merged commit d428889 into sdf14 Jun 27, 2024
12 of 13 checks passed
@scpeters scpeters deleted the scpeters/ci_push_branch branch June 27, 2024 22:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants