Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump main to sdformat 16.0.0~pre1 #1487

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Bump main to sdformat 16.0.0~pre1 #1487

merged 2 commits into from
Oct 16, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Oct 9, 2024

🎉 New feature

Summary

Bump main to sdformat 16.0.0~pre1

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested review from azeey and scpeters as code owners October 9, 2024 16:28
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor

iche033 commented Oct 9, 2024

test fixing macOS github ci workflow: e4a4c68

@scpeters
Copy link
Member

scpeters commented Oct 9, 2024

test fixing macOS github ci workflow: e4a4c68

that is a good fix, but the problem appears to be that homebrew added python@3.13 and our homebrew formula builds python bindings for gz-math8 with python@3.12 (see gz-math8.rb:23), but now cmake is finding python 3.13 when searching for the interpreter so tests fail when they can't find the gz-math8 bindings

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

@scpeters
Copy link
Member

scpeters commented Oct 9, 2024

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

I think we need an adjustment to the -DPython_EXECUTABLE=... cmake arg to point to the version of python that we currently support

some homebrew formula build bindings for multiple versions of python, but that seems a bit complicated

@scpeters
Copy link
Member

scpeters commented Oct 9, 2024

We've faced this before; I think we can hard-code which python version we want to find, let me see if I can find it

I think we need an adjustment to the -DPython_EXECUTABLE=... cmake arg to point to the version of python that we currently support

some homebrew formula build bindings for multiple versions of python, but that seems a bit complicated

I've opened osrf/homebrew-simulation#2834 to track this issue

@iche033
Copy link
Contributor

iche033 commented Oct 16, 2024

the homebrew python issue is being addressed separately. Merging this in first.

@iche033 iche033 merged commit 3e7e943 into main Oct 16, 2024
8 of 11 checks passed
@iche033 iche033 deleted the merge_15_main_20241009 branch October 16, 2024 19:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants