Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bzlmod support #1499

Merged
merged 9 commits into from
Nov 12, 2024
Merged

bzlmod support #1499

merged 9 commits into from
Nov 12, 2024

Conversation

shameekganguly
Copy link
Contributor

🎉 New feature

Summary

Bzlmod support
Original PR from @mjcarroll: #1493

Test it

bazel build sdformat

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Shameek Ganguly <shameek@google.com>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Nov 7, 2024
@shameekganguly shameekganguly changed the title Shameek/bzlmod bzlmod support Nov 7, 2024
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (sdf15@bf36eb7). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             sdf15    #1499   +/-   ##
========================================
  Coverage         ?   92.47%           
========================================
  Files            ?      138           
  Lines            ?    18322           
  Branches         ?        0           
========================================
  Hits             ?    16943           
  Misses           ?     1379           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll changed the base branch from sdf15 to mjcarroll/bzlmod November 7, 2024 14:19
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
@shameekganguly shameekganguly marked this pull request as ready for review November 12, 2024 06:04
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
Signed-off-by: Shameek Ganguly <shameek@google.com>
@mjcarroll mjcarroll merged commit 3e0f966 into mjcarroll/bzlmod Nov 12, 2024
8 checks passed
@mjcarroll mjcarroll deleted the shameek/bzlmod branch November 12, 2024 15:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants