Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Permit to test when building bindings separately from main library #1509

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Nov 16, 2024

🦟 Bug fix

Follow up of #1491 . #1491 enable the compilation of bindings separately from the main library, but does not permit to set BUILD_TESTING:BOOL=ON in those binding-only builds.

Summary

This PR permits to pass -DBUILD_TESTING:BOOL=ON in bindings-only builds, by:

  • Ensuring that ${PROJECT_BINARY_DIR}/include/test_config.hh is generated also in bindings-only builds,
  • Use CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_SOURCE_DIR when creating the tests, as the CMAKE_CURRENT_SOURCE_DIR variable have a consistent value that is not influenced on which is the root directory of the CMake build.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@scpeters scpeters merged commit 4ebe022 into gazebosim:sdf15 Nov 18, 2024
16 checks passed
@traversaro traversaro deleted the patch-9 branch November 18, 2024 14:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants