Collision: don't load Surface without <surface> #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
This was referenced May 2, 2020
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
May 4, 2020
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
May 4, 2020
|
RobotLocomotion/drake#13218 confirms that this removes the behavior change, at least insofar as Drake notices. |
EricCousineau-TRI
approved these changes
May 7, 2020
azeey
approved these changes
May 7, 2020
scpeters
added a commit
that referenced
this pull request
May 12, 2020
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
May 12, 2020
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
May 15, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
May 15, 2020
…m#268 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
May 15, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
May 15, 2020
…m#268 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
May 15, 2020
scpeters
added a commit
that referenced
this pull request
Jun 2, 2020
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Jun 2, 2020
traversaro
pushed a commit
to traversaro/sdformat
that referenced
this pull request
Sep 5, 2020
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
traversaro
pushed a commit
to traversaro/sdformat
that referenced
this pull request
Sep 5, 2020
…m#268 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a minor behavior change in Bitbucket pull request 660 that started adding empty
<surface>elements to the sdf element in a Collision DOM element if it didn't already have a<surface>element. This has caused some issues for downstream users ( RobotLocomotion/drake#13201 ), and it's a minor thing to change, so I've reverted the behavior change. I also recommended where to change the downstream code to be less brittle ( RobotLocomotion/drake#13201 (comment) ).This was originally reported in #267.