Skip to content

Commit

Permalink
Fix azure pre-signed urls
Browse files Browse the repository at this point in the history
Azure URL signing was broken. The journal prefix was being duplicated in the
URL, which resulted in unusable URLs. Clients would fail with a 403 response
when attempting to fetch the fragment.  This removes the extra prefix to
hopefully allow signing to work.
  • Loading branch information
psFried committed Aug 11, 2023
1 parent 44a9a18 commit 33ae64f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion broker/fragment/store_azure.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func (a *azureBackend) SignGet(ep *url.URL, fragment pb.Fragment, d time.Duratio
if err != nil {
return "", err
}
return fmt.Sprintf("%s/%s/%s?%s", cfg.containerURL(), cfg.prefix, blobName, sasQueryParams.Encode()), nil
return fmt.Sprintf("%s/%s?%s", cfg.containerURL(), blobName, sasQueryParams.Encode()), nil
}

func (a *azureBackend) Exists(ctx context.Context, ep *url.URL, fragment pb.Fragment) (bool, error) {
Expand Down

0 comments on commit 33ae64f

Please # to comment.