Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

performance instrumentation and configurable read channel sizes #306

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Sep 23, 2021

Issue #305


This change is Reviewable

Instrument runtime/trace with notable logs of transaction lifecycle
events, to make it easier to interpret transaction stages within a
`go tool trace` view.

Also add a debug log of per-transaction timings.

Issue #TBD
Allow for configuration of this knob.

Issue #305
@jgraettinger jgraettinger marked this pull request as ready for review September 23, 2021 16:45
Copy link
Contributor

@snowzach snowzach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I can fully digest the transaction processing flow but the relevant changes LGTM.

@jgraettinger jgraettinger merged commit a1ff40b into master Sep 23, 2021
@jgraettinger jgraettinger deleted the johnny/perf branch September 23, 2021 21:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants