Register Protobuf Enums #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2022 11:35
The GRPC Gateway needs to read the enum definitions to properly translate messages. However, it only reads these definitions from goproto's registry, not gogoproto's registry. Luckily, gogoproto supports this as an option. See https://jbrandhorst.com/post/gogoproto/ for more information about the tenuous compatibility between gogoproto and the GRPC gateway.
jgraettinger
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @saterus)
saterus
pushed a commit
to estuary/flow
that referenced
this pull request
Apr 22, 2022
Brings in gazette/core#320 to support GRPC Gateway.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use https://github.com/grpc-ecosystem/grpc-gateway with Gazette's broker/consumer services, we need to enable a gogoproto option to register any enums with the goproto registry.
The GRPC Gateway needs to read the enum definitions to properly translate messages. However, it only reads these definitions from goproto's registry, not gogoproto's registry. Luckily, gogoproto supports this as an option.
See https://jbrandhorst.com/post/gogoproto/ for more information about the tenuous compatibility between gogoproto and the GRPC gateway.
This change is