Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow customizing server Listener #327

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Allow customizing server Listener #327

merged 1 commit into from
Aug 25, 2022

Conversation

psFried
Copy link
Contributor

@psFried psFried commented Aug 25, 2022

Adds a function to server.go that allows passing the net.Listener used
with starting a Server. This is intended to allow users to create
servers using TLS.

Note that this is only a library change. No TLS options were added to Gazette binaries as of yet.


This change is Reviewable

Adds a function to server.go that allows passing the `net.Listener` used
with starting a Server. This is intended to allow users to create
servers using TLS.
@psFried psFried requested a review from jgraettinger August 25, 2022 04:42
Copy link
Contributor

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit 54b34a7 into master Aug 25, 2022
@psFried psFried deleted the phil/server-tls branch August 25, 2022 17:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants