Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

journal client: force using http1.1 when fetching fragments from clou… #368

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

psFried
Copy link
Contributor

@psFried psFried commented Mar 13, 2024

…d storage

We've seen some unfortunate issues with the http2 client, where certain types of transport failures can cause a connection to be unusable, and yet the client will still re-use it for new http2 streams. Disabling http2 is intended to be a short term fix, until the root cause can be identified and fixed.


This change is Reviewable

@psFried psFried requested a review from jgraettinger March 13, 2024 22:16
Copy link
Contributor

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % CI

…d storage

We've seen some unfortunate issues with the http2 client, where certain types
of transport failures can cause a connection to be unusable, and yet the client
will still re-use it for new http2 streams. Disabling http2 is intended to be a
short term fix, until the root cause can be identified and fixed.
@psFried psFried merged commit 81d0aa5 into master Mar 13, 2024
1 check passed
@psFried psFried deleted the phil/h2-client branch March 13, 2024 22:46
psFried added a commit to estuary/flow that referenced this pull request Mar 14, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants