Skip to content

Conversation

dmitry-shechtman
Copy link
Contributor

According to Pan Docs:

If the old licensee code is $01, or the old licensee code is $33 and the new licensee code is "01" ($30 $31), then B is the sum of all 16 title bytes. Otherwise, B is $00. As indicated by the “+ 1” in the “AGB (DMG mode)” column, if on AGB, that value is increased by 12.

This was referenced Aug 12, 2025
@Rangi42
Copy link
Collaborator

Rangi42 commented Aug 12, 2025

Hmm. These have been around since v3.0, so it would count as a breaking change. And we'll still want to support them via hardware_compat.inc.

If we're adding and removing bootup register constants anyway, I'd like to take time and make sure we get it right+complete. Maybe someone more experienced than me with console detection can review Pan Docs and ensure our constants are good?

@Rangi42
Copy link
Collaborator

Rangi42 commented Aug 12, 2025

Also, can you please just have one "bootup register PR"? Don't worry about pushing more commits to it; after reviews/edits, if/when it's approved, we'll squash it into one commit with a sensible message (and update the hardware.inc version and history accordingly).

@dmitry-shechtman
Copy link
Contributor Author

I guess this one is 6.0 then (applies to both comments).

@Rangi42
Copy link
Collaborator

Rangi42 commented Aug 12, 2025

Okay, please close your other PR and make all bootup-related changes in this one?

@dmitry-shechtman
Copy link
Contributor Author

May I ask why? The other one isn't breaking.

@Rangi42
Copy link
Collaborator

Rangi42 commented Aug 12, 2025

Easier to deal with one changeset related to "bootup B registers".

@Rangi42
Copy link
Collaborator

Rangi42 commented Aug 12, 2025

Superseded by #75

@Rangi42 Rangi42 closed this Aug 12, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants