Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Don't treat labels and macros differently in column 1 #1512

Closed
Rangi42 opened this issue Sep 22, 2024 · 0 comments · Fixed by #1515
Closed

Don't treat labels and macros differently in column 1 #1512

Rangi42 opened this issue Sep 22, 2024 · 0 comments · Fixed by #1515
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Milestone
v0.9.0

Comments

@Rangi42
Copy link
Contributor

Rangi42 commented Sep 22, 2024 •
edited
Loading

Remove the atLineStart condition for determining whether an identifier lexes as ID or LABEL (keep the check for peek() == ':')). This would mean that column-1 mac args behaves as a macro invocation, which is probably what users want. (It would also mean that although column-1 Label: is still a label, column-1 Label : is not, and would probably complain "Macro "Label" not defined".)
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Sep 22, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Sep 22, 2024
@Rangi42 Rangi42 changed the title Lexer updates Don't treat labels and macros differently in column 1 Sep 22, 2024
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Sep 22, 2024
@Rangi42
Don't treat labels and macros differently in column 1
0141ad3 
Fixes gbdev#1512
@Rangi42 Rangi42 mentioned this issue Sep 22, 2024
Merged
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Sep 22, 2024
@Rangi42
Don't treat labels and macros differently in column 1
b43ae73 
Fixes gbdev#1512
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Sep 22, 2024
@Rangi42
Don't treat labels and macros differently in column 1
936ebba 
Fixes gbdev#1512
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Sep 22, 2024
@Rangi42
Don't treat labels and macros differently in column 1
9186b61 
Fixes gbdev#1512
Rangi42 added a commit to Rangi42/rgbds that referenced this issue Sep 22, 2024
@Rangi42
Don't treat labels and macros differently in column 1
a8e5084 
Fixes gbdev#1512
@ISSOtm ISSOtm closed this as completed in 6b89938 Sep 22, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Don't treat labels and macros differently in column 1 Rangi42/rgbds
1 participant
@Rangi42