Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Keep the object version as RGB9; only increment the revision to 10 #1413

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Keep the object version as RGB9; only increment the revision to 10 #1413

merged 1 commit into from
Jun 21, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jun 21, 2024

After this merges, gbdev/rgbds-obj#2 should be updated correspondingly.

@Rangi42 Rangi42 added rgbasm This affects RGBASM rgblink This affects RGBLINK labels Jun 21, 2024
@Rangi42 Rangi42 added this to the v0.8.0 milestone Jun 21, 2024
@Rangi42 Rangi42 requested a review from ISSOtm June 21, 2024 14:45
@Rangi42 Rangi42 mentioned this pull request Jun 21, 2024
Merged
ISSOtm
ISSOtm approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it's a better idea. The version doesn't mean much anymore, and "RGBA" is much more likely to conflict with some colour format.

@ISSOtm ISSOtm merged commit 240ab8e into gbdev:master Jun 21, 2024
22 checks passed
@Rangi42 Rangi42 deleted the rgb9 branch June 21, 2024 15:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
rgbasm This affects RGBASM rgblink This affects RGBLINK
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rangi42 @ISSOtm