Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix generating a palette overriding a previous pal spec #1415

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jun 25, 2024

Every method of defining a palette spec (from a PSP file, an ACO file, an embedded palette, etc) was already clearing the spec before initializing it, except for generatePalSpec.

Fixes #1414 (@ZoomTen please confirm)

@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX labels Jun 25, 2024
@Rangi42 Rangi42 added this to the v0.8.0 milestone Jun 25, 2024
@Rangi42 Rangi42 requested a review from ISSOtm June 25, 2024 16:16
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the kind of issue encountered by the test case, on top of #1414, so it's good to merge either way.

@ISSOtm ISSOtm merged commit ed5529d into gbdev:master Jun 25, 2024
22 checks passed
@Rangi42 Rangi42 deleted the fix-multiple-pal-specs branch June 25, 2024 16:32
@ZoomTen
Copy link

ZoomTen commented Jun 26, 2024

Fix confirmed, thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! rgbgfx This affects RGBGFX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rgbgfx: Assertion failure when both inline palette spec and embedded palette spec are specified
3 participants