Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deprecate LD with [C] #1574

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Deprecate LD with [C] #1574

merged 1 commit into from
Dec 11, 2024

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Dec 9, 2024 •
edited
Loading

Fixes #1573

Be sure to update the gbdev.io opcode table after this.

@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels Dec 9, 2024
@Rangi42 Rangi42 added this to the v0.9.0 milestone Dec 9, 2024
@Rangi42 Rangi42 requested a review from ISSOtm December 9, 2024 18:10
@Rangi42
Copy link
Contributor Author

Rangi42 commented Dec 9, 2024 •
edited
Loading

Note that gbz80(7) already documents these instructions as LDH, without mentioning the LD alternatives.

The gbdev.io opcode table, on the other hand, documents it as LD.

@Rangi42 Rangi42 merged commit f44de0c into gbdev:master Dec 11, 2024
22 checks passed
@Rangi42 Rangi42 deleted the deprecate-ld-c branch December 11, 2024 02:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Deprecate ld [c], a and ld a, [c]
2 participants
@Rangi42 @ISSOtm