Skip to content

Commit

Permalink
MappingBrowser: Don't reload all registries when (un)checking a regis…
Browse files Browse the repository at this point in the history
…try (#168)
  • Loading branch information
stefandesu committed Dec 13, 2018
1 parent c9b24e6 commit db79105
Showing 1 changed file with 19 additions and 5 deletions.
24 changes: 19 additions & 5 deletions src/components/MappingBrowser.vue
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ export default {
prop: "mappingBrowserShowRegistry",
value: Object.assign({}, this.$settings.mappingBrowserShowRegistry, { [registry.uri]: value })
})
this.$store.commit("mapping/setRefresh")
this.$store.commit("mapping/setRefresh", { registry: registry.uri })
}
})
}
Expand Down Expand Up @@ -565,10 +565,7 @@ export default {
for (let registry of this.mappingRegistries) {
// Check if enabled
if (!this.showRegistry[registry.uri]) {
continue
}
let addSeparator = !isFirst
isFirst = false
Expand All @@ -581,6 +578,15 @@ export default {
type: "loading",
registry,
}
if (!this.showRegistry[registry.uri]) {
// Replace loadingRow with a hidden dummy row
loadingRow = {
"_wholeRow": true,
"_rowClass": "mappingBrowser-table-row-hidden",
value: "",
registry,
}
}
if (partialReload) {
if (registry.uri != registryToReload) {
// Skip
Expand All @@ -594,6 +600,11 @@ export default {
this.items.push(loadingRow)
}
// Check if enabled
if (!this.showRegistry[registry.uri]) {
continue
}
let promise = this.$store.dispatch({ type: "mapping/getMappings", ...params, registry: registry.uri, all: true }).then(mappings => {
// Check loadingId
Expand Down Expand Up @@ -1013,6 +1024,9 @@ export default {
.mappingBrowser-table-row-loading > span > div {
margin: 0 auto;
}
.mappingBrowser-table-row-hidden {
display: none;
}
.mappingBrowser-beforeSeparatorRow {
padding-bottom: 10px !important;
}
Expand Down

0 comments on commit db79105

Please # to comment.