Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MappingEditor: Indicate whether a mapping has been edited and not saved yet #115

Closed
2 tasks done
nichtich opened this issue Aug 14, 2018 · 4 comments
Closed
2 tasks done
Assignees
Labels
feature Additional functionality user experience Usage should be fun and easy
Milestone

Comments

@nichtich
Copy link
Member

nichtich commented Aug 14, 2018

Given a mapping has been saved. If then the mapping is modified (e.g. change the mapping type) it should be visible as modified.

  • grey out "save" icon if nothing has been changed
  • visual indicator if mapping has been changed

Probably requires #73. The issue is complicated because several kinds of changes are possible and it depends on whether the mapping has an URI or not.

@nichtich nichtich added user experience Usage should be fun and easy feature Additional functionality labels Aug 14, 2018
@stefandesu
Copy link
Member

I agree that MappingEditor should behave more like an actual editor. Currently there is not really a connection to the mappings already in the MappingBrowser.

Probably requires #73. The issue is complicated because several kinds of changes are possible and it depends on whether the mapping has an URI or not.

I'm not sure #73 has anything to do with this (or maybe I still misunderstood that issue). Also, do you mean by "has an URI" that it has an identifier in general? Currently, I calculate the identifiers for all mappings that are loaded anyway, so this wouldn't be an issue. The issue is more that we have to keep track of the original mapping if the mapping is changed in a way that changes the identifier. I guess that's what you meant by "The issue is complicated because several kinds of changes are possible".

@stefandesu stefandesu self-assigned this Aug 22, 2018
stefandesu added a commit that referenced this issue Aug 22, 2018
Add a delete button (#114). More discussion necessary.
Also for #115.
@stefandesu
Copy link
Member

This is now partly implemented in the latest dev. Do you have a suggestion for a visual indicator that clearly shows that the mapping has been changed from the original?

@nichtich
Copy link
Member Author

The "edit mapping" icon could be used. It's not perfectly easy but the same button at other places will reload the original mapping. I'd also change to order of icons:

  • clear
  • export/link (this might actually be one)
  • visual separator, e.g. whitespace
  • reset (with edit button)
  • save
  • delete

@stefandesu
Copy link
Member

I'm not sure I understand what you mean. So the reset button would basically discard the changes you made to the mapping and set it back to the original? But it would have the edit icon? That doesn't make any sense.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature Additional functionality user experience Usage should be fun and easy
Projects
None yet
Development

No branches or pull requests

2 participants