-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MappingEditor: Indicate whether a mapping has been edited and not saved yet #115
Comments
I agree that MappingEditor should behave more like an actual editor. Currently there is not really a connection to the mappings already in the MappingBrowser.
I'm not sure #73 has anything to do with this (or maybe I still misunderstood that issue). Also, do you mean by "has an URI" that it has an identifier in general? Currently, I calculate the identifiers for all mappings that are loaded anyway, so this wouldn't be an issue. The issue is more that we have to keep track of the original mapping if the mapping is changed in a way that changes the identifier. I guess that's what you meant by "The issue is complicated because several kinds of changes are possible". |
This is now partly implemented in the latest dev. Do you have a suggestion for a visual indicator that clearly shows that the mapping has been changed from the original? |
The "edit mapping" icon could be used. It's not perfectly easy but the same button at other places will reload the original mapping. I'd also change to order of icons:
|
I'm not sure I understand what you mean. So the reset button would basically discard the changes you made to the mapping and set it back to the original? But it would have the edit icon? That doesn't make any sense. |
Given a mapping has been saved. If then the mapping is modified (e.g. change the mapping type) it should be visible as modified.
Probably requires #73. The issue is complicated because several kinds of changes are possible and it depends on whether the mapping has an URI or not.
The text was updated successfully, but these errors were encountered: