Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MappingBrowser: Load information about concepts in fewer requests #317

Closed
3 tasks done
stefandesu opened this issue Mar 21, 2019 · 2 comments
Closed
3 tasks done
Labels
cleanup code cleanup, refactoring, testing... user experience Usage should be fun and easy
Milestone

Comments

@stefandesu
Copy link
Member

stefandesu commented Mar 21, 2019

Currently, MappingBrowser loads labels (and notations if necessary) for all concepts in all mappings each with a separate request. These requests should be bundled by concept registry, i.e. having only a single request for all concepts from jskos-server and another single request for all concepts from DANTE. This would greatly improve performance when there are a lot of mappings or suggestions shown.

  • Add option to load multiple concepts to providers/concept-api-provider.js.
  • Add option to load multiple concepts to mixins/objects.js.
  • Use that new option in MappingBrowser.
@stefandesu stefandesu added user experience Usage should be fun and easy cleanup code cleanup, refactoring, testing... labels Mar 21, 2019
@stefandesu stefandesu added this to the 0.9.0 milestone Mar 21, 2019
@nichtich
Copy link
Member

nichtich commented Mar 21, 2019 via email

@stefandesu
Copy link
Member Author

@nichtich Any particular reason why bundling by concept scheme may be cleaner to implement? It would actually introduce one more unnecessary step because we still need to retrieve the provider from the concept scheme to make the request. As provider information is also associated with concept objects, we'd save one step and possibly a few requests by using that directly.

stefandesu added a commit that referenced this issue Mar 28, 2019
Up to 25 concepts from the same provider are now fetched simultaneously when loading the labels for concepts in MappingBrowser.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cleanup code cleanup, refactoring, testing... user experience Usage should be fun and easy
Projects
None yet
Development

No branches or pull requests

2 participants