Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create and save into concordances, assign mappings to a concordances #98

Closed
stefandesu opened this issue Jun 6, 2019 · 6 comments
Closed
Labels
feature Additional functionality

Comments

@stefandesu
Copy link
Member

This should eventually be possible in Cocoda. Things to consider:

  • Who can write into which concordance? (Only creator? Can others be given the rights?)
  • jskos-server would need to be adjusted that those mappings are not deleted on reimport of a concordances.

...

@nichtich
Copy link
Member

nichtich commented Nov 1, 2019

There is a workaround using comments (#453). One gbv/cocoda#406 is available, entirely remove mapping comments.

@stefandesu
Copy link
Member Author

stefandesu commented Jan 15, 2020

Is this something that needs to be discussed with the workflow group, or are the requirements for this feature relatively clear? By the way, mapping comments were already removed.

@nichtich
Copy link
Member

This should be discussed on the meeting at March 30th.

@nichtich nichtich transferred this issue from gbv/cocoda Jun 3, 2020
@nichtich
Copy link
Member

nichtich commented Jun 3, 2020

Saving a mapping into a concordance is basically saving a mapping with field partOf referencing an existing concordance (see #99 to manage concordance metadata). The rest is

  • issues of consistency
    • should a mapping only be allowed to be part of one concordance at most? (I think so for simplicity)
    • fromScheme and toScheme of a mapping must match the same fields of its concordance
  • issues of authentification: who should be allowed to write mappings into concordances (and to remove mappings from)?
    • identies listed in creator should always be allowed
    • plus identies listed in contributor (so the creator could add contributors via editing concordance metadata)
    • we may later want user groups but this is not needed to start with
    • open question: what if a mapping with author X is part of a concordance but X is not allowed to edit into this concordance (e.g. happened during import or the author was removed from contributor)? - should the author be allowed to delete the mapping and to remove the mapping from the concordance? Otherwise X cannot edit the mapping anymore in this case (actually this may be a wanted feature)
  • issues of workflow and user interface design: how to select whether/when to assign mappings to concordances. This issues are not part of jskos-server.

@nichtich nichtich added the feature Additional functionality label Jun 3, 2020
@stefandesu stefandesu added this to the 2.0.0 milestone Jun 15, 2020
@stefandesu
Copy link
Member Author

I agree with all your points in the last comment and I personally think we could already start to implement this.

  • open question: what if a mapping with author X is part of a concordance but X is not allowed to edit into this concordance (e.g. happened during import or the author was removed from contributor)? - should the author be allowed to delete the mapping and to remove the mapping from the concordance? Otherwise X cannot edit the mapping anymore in this case (actually this may be a wanted feature)

My suggestion would be to disallow editing or deleting the mapping in this case. Adding this functionality later would not be a breaking change in my opinion, so better to do it this way around for now.

stefandesu added a commit that referenced this issue Oct 19, 2020
…101)

Notes:
- Currently, this is a separate file and is not tested.
- Next step is to write an additional script that replaces the --reset option of the import script.
- Then, the previous import script can be replaced and the tests adjusted so that they use the reset script instead of --reset.
- Mappings/concordances are still imported directly in the database because the service methods do not yet offer sufficient functionality (needs #98 and #99).
@stefandesu
Copy link
Member Author

I'm closing this issue in favor of #99 since we've been discussion the same things over there...

@stefandesu stefandesu removed this from the 1.3.0 milestone Dec 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature Additional functionality
Projects
None yet
Development

No branches or pull requests

2 participants