Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implemented MagmaCoreObjectDatabase Queries #6

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Implemented MagmaCoreObjectDatabase Queries #6

merged 1 commit into from
Jun 22, 2021

Conversation

GCHQDeveloper42
Copy link
Contributor

@GCHQDeveloper42 GCHQDeveloper42 commented Jun 15, 2021 •
edited
Loading

Resolves #4

Implemented findByPredicateIriOnly and findByPredicateIriAndStringCaseInsensitive queries in MagmaCoreObjectDatabase using the hasValue and hasStringValueIgnoreCase functions of HqdmObject.

@GCHQDeveloper42
Implemented findByPredicateIriOnly and findByPredicateIriAndStringCas…
d2121cf 
…eInsensitive queries in MagmaCoreObjectDatabase.
@GCHQDeveloper42 GCHQDeveloper42 added the enhancement New feature or request label Jun 15, 2021
GCHQDeveloper56
GCHQDeveloper56 approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@GCHQDeveloper56 GCHQDeveloper56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that these are good completion of the placeholders in the code as originally released.

@GCHQDeveloper42 GCHQDeveloper42 merged commit 594d123 into main Jun 22, 2021
@GCHQDeveloper42 GCHQDeveloper42 deleted the implement-objectdb-queries branch July 15, 2022 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GCHQDeveloper56 GCHQDeveloper56 GCHQDeveloper56 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement findByPredicateIriOnly in MagmaCoreObjectDatabase
2 participants
@GCHQDeveloper42 @GCHQDeveloper56