Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added some account tests #179

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Conversation

nate-lavoy
Copy link
Collaborator

@nate-lavoy nate-lavoy commented Mar 7, 2025

-added tests for accounts views.py
-ensured flake8 and tests run on pr as well as merge

@nate-lavoy nate-lavoy requested a review from frankx2023 March 7, 2025 03:27
@frankx2023 frankx2023 requested a review from Copilot March 7, 2025 03:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR adds tests for account-related views and updates the CI configuration.

  • Added unit tests in accounts/tests/test_views.py for home, register, login, logout, and verify views.
  • Updated .travis.yml to include linting via flake8 and running tests with coverage.
  • Removed the unused accounts/tests.py file.

Reviewed Changes

File Description
accounts/tests/test_views.py Added comprehensive tests for key account view functions.
.travis.yml Updated to run flake8 and execute tests with coverage.
accounts/tests.py Removed unused file to clean up the codebase.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.travis.yml:49

  • [nitpick] Consider adding a subsequent step (e.g., 'coverage report') to output the coverage summary after running the tests to enhance feedback on test coverage.
        - coverage run manage.py test
Copy link
Collaborator

@frankx2023 frankx2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@frankx2023 frankx2023 merged commit fb80c83 into gcivil-nyu-org:develop Mar 7, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants