-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature Request - Add a icloud3.display_message service option #417
Comments
I think I've made the changes that would need to be merged, for my own Feature Request... it's tested and working but I'll admit to being pretty ignorant of how you do this on the GitHub side, I've updated my own branch, it says it can be merged but I don't want to do anything to mess this up :) I think I already hit a button or two on GitHub to make alerts fire in your direction lol. I canceled them and all my changes should be contained to my fork for easy commit review or... merge. |
I do not use GitHub to manage my changes on my location RPis. Since I am the only developer, it is not needed for my testing and would just get in the way
Zip the files you have changed and email them to ***@***.*** I can then identify the changes and apply them to my master code. If you did an update on GitHub, would download it and then do the comparison so that would make it easier for both of us.
Looking forward to seeing the mods.
Gary
Gary Cobb
…________________________________
From: DuncanIdahoCT ***@***.***>
Sent: Wednesday, March 5, 2025 1:41:19 PM
To: gcobb321/icloud3_v3 ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [gcobb321/icloud3_v3] Feature Request - Add a icloud3.display_message service option (Issue #417)
I think I've made the changes that would need to be merged, for my own Feature Request... it's tested and working but I'll admit to being pretty ignorant of how you do this on the GitHub side, I've updated my own branch, it says it can be merged but I don't want to do anything to mess this up :) I think I already hit a button or two on GitHub to make alerts fire in your direction lol. I canceled them and all my changes should be contained to my fork for easy commit review or... merge.
—
Reply to this email directly, view it on GitHub<#417 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIOOVBY7JX773KU4WLRH4J32S5AM7AVCNFSM6AAAAABX54NRAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBRG43TGMRYGY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
[DuncanIdahoCT]DuncanIdahoCT left a comment (gcobb321/icloud3_v3#417)<#417 (comment)>
I think I've made the changes that would need to be merged, for my own Feature Request... it's tested and working but I'll admit to being pretty ignorant of how you do this on the GitHub side, I've updated my own branch, it says it can be merged but I don't want to do anything to mess this up :) I think I already hit a button or two on GitHub to make alerts fire in your direction lol. I canceled them and all my changes should be contained to my fork for easy commit review or... merge.
—
Reply to this email directly, view it on GitHub<#417 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIOOVBY7JX773KU4WLRH4J32S5AM7AVCNFSM6AAAAABX54NRAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBRG43TGMRYGY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sent, had to look "elsewhere" for your email as it was scrubbed above. This'll be the first contribution I've made... possibly I mean unless you say my mods are garbage ;) Thanks so much for the work, it was already perfect! this just makes it... comprehensive of it's ability to use pyicloud. |
Got the file and will check it out. |
In addition to icloud3.find_iphone_alert and icloud3.lost_device_alert, I would request that we get access to the 3rd related service that pyicloud provides for which is "display_message"
Find iPhone hints that it can display a message but after some testing it seems this is/is now not possible
Lost Mode isn't ideal as it has other implications even if it does allow some form of customizable messages to be displayed on devices
The actual pyicloud class PyiCloud_DeviceSvc() has display_message in addition to play_sound, and lost_device. I'm proposing this is added as a service to icloud3. Being able to send alerts and customize a message and specify sounds=true/false is quite useful for those of us who use icloud alerts to bring attention to critical HA alerts such as water leak sensors refrigerator temp sensors, etc...
I've tested that display_message works and allows custom messages to be displayed either silently or with sound that can't be overridden as silent on the device which is ideal for life/fire safety or water leak alerts. The way I tested was preempting the icloud3.lost_device_alert service in icloud3 to instead call the pyicloud display_message.
Thanks
The text was updated successfully, but these errors were encountered: