Use name hint when server is not providing custom scalar type name #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
elprans
approved these changes
Sep 22, 2023
fantix
added a commit
that referenced
this pull request
Sep 22, 2023
Changes ======= * Add an fts::language type that is encoded as text (#417) (by @msullivan in 9e7d2d2 for #417) * Drop support of Python 3.7 (#435) (by @fantix in 758a391 for #435) Fixes ===== * Fix codegen for pgvector (#447) (by @fantix in 7aa58bd for #447) * Use name hint when server is not providing custom scalar type name (#461) (by @arunaruljothi in 6c6225e for #457)
fantix
added a commit
that referenced
this pull request
Sep 22, 2023
Changes ======= * Add an fts::language type that is encoded as text (#417) (by @msullivan in 9e7d2d2 for #417) * Drop support of Python 3.7 (#435) (by @fantix in 758a391 for #435) Fixes ===== * Fix codegen for pgvector (#447) (by @fantix in 7aa58bd for #446) * Use name hint when server is not providing custom scalar type name (#461) (by @arunaruljothi in 6c6225e for #457)
Merged
fantix
added a commit
that referenced
this pull request
Sep 22, 2023
Changes ======= * Add an fts::language type that is encoded as text (#417) (by @msullivan in 9e7d2d2 for #417) * Drop support of Python 3.7 (#435) (by @fantix in 758a391 for #435) Fixes ===== * Fix codegen for pgvector (#447) (by @fantix in 7aa58bd for #446) * Use name hint when server is not providing custom scalar type name (#461) (by @arunaruljothi in 6c6225e for #457)
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like mentioned in #457, this is probably a server bug. When fixed, the test assertion in this PR shall be updated (instead of
we should probably have:
for query:
).
Ah, this bug is already fixed in EdgeDB 4.0 -
now I'll have to fix the assertions.The test is now fixed.Fixes #457