Make 'admin' the default role instead of 'edgedb' #8010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantix
approved these changes
Nov 21, 2024
But if 'edgedb' does not exist and it is specified at login, treat it as 'admin'.
msullivan
force-pushed
the
rename-default-role
branch
from
5bc4aeb to
e4093eb
Compare
This was referenced Nov 27, 2024
msullivan
added a commit
that referenced
this pull request
Nov 28, 2024
This makes mirrors the logic for logins and avoid breaking setup scripts, such as those in our client test suites and possibly in some user suites. Follow-up to #8010. Makes geldata/gel-python#550 unnecessary.
msullivan
added a commit
that referenced
this pull request
Nov 28, 2024
…8048) This makes mirrors the logic for logins and avoid breaking setup scripts, such as those in our client test suites and possibly in some user suites. Follow-up to #8010. Makes geldata/gel-python#550 unnecessary.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But if 'edgedb' does not exist and it is specified at login, treat it
as 'admin'.