Skip to content
This repository has been archived by the owner on Nov 10, 2017. It is now read-only.

Gmpe bindi2011 #254

Closed
wants to merge 2 commits into from
Closed

Conversation

francescoingv
Copy link
Contributor

No description provided.

@g-weatherill
Copy link
Contributor

In general the naming convention we follow for XXXX et al. (####) is simply xxxx_####, so in this case the function would be better named as bindi_2011.py

""")


class Bindietal2011NoRake(BindiEtAl2011):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming convention would make this BindiEtAl2011NoRake (i.e. make the e and a of et al upper case)

@g-weatherill
Copy link
Contributor

The GMPE is missing the corresponding docs that would make them visible to the documentation

  1. Add "bindi_2011" below line 24 of the doc/gsim/index.rst file.
  2. Create a file in the directory doc/gsim named "bindi_2011.rst". The contents of that file should be (assuming the changes in the previous comments are implemented):

"=================
"Bindi et al. 2011
"=================

.. module:: openquake.hazardlib.gsim.bindi_2011

.. autoclass:: BindiEtAl2011
:members:

.. autoclass:: BindiEtAl2011NoRake
:members:"

(See other .rst files for the example)

g-weatherill added a commit that referenced this pull request Nov 17, 2014
Implements the Bindi et al. (2011) GMPE
(Cleaned up implementation from Francesco Martinelli, INGV: #254)
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants