Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: added support for dirty files #368
feat: added support for dirty files #368
Changes from 8 commits
c24bfe1
dc6ef9e
2d59bd6
50beb9e
ec36c83
8f44b54
d1933ad
e54fe0d
fb9e1ff
9bdac23
d19234f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is clear enough what the feature does, maybe an example of why it would be useful?
I also think we should update
faq/gitdirty.md
with how this feature can help.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rewrite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've generally found this change hard to understand from the naming and documentation. The text does not really tell me what happens with the 'dirtyFiles' are they only ignored or are they staged / committed by uplift. My assumption is that you want the Uplift to stage the files otherwise you could just add them to the
.gitignore
file? I feel the name of this config should describe what you want uplift to do with them. So if completely ignoring then maybeignoreFiles
, if staging then maybestageFiles
oraddFiles
orincludeArtifacts
(thinking build artifacts that you want in a 'release').There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the name includeArtifacts - renaming it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow Glob patterns? Can this be added later without breaking compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldnt like to introduce Glob patterns - only explicit files should only be allowed so users are aware of any extra files which shouldnt have changed