[ENH] Add interpolation options type selection and improve documentation | GEN-12034 #1020
+42
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Leguark
changed the title
Graphite Automations"Add gempy label" took an action on this PR • (05/02/25)1 label was added to this PR based on Miguel de la Varga's automation. |
Leguark
changed the title
Replaces hardcoded interpolation initialization with an enum-based system (`InterpolationOptionsType`) for flexibility. Removes unused tests and updates dependencies to `gempy_engine~=2025.1`.
…lease updates" This reverts commit 50e3ebd.
Updated the gempy_viewer dependency to ensure compatibility by using an exact version specification. This helps to avoid potential issues arising from unintended updates.
This update fixes a potential issue in the gempy_engine dependency. Ensures compatibility and correctness with the latest patched version.
Open
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhanced the
create_geomodelfunction to support different interpolation options types through a new enum-based approach. AddedInterpolationOptionsTypeenum withDENSE_GRIDandOCTREEoptions to allow users to explicitly choose their preferred interpolation method. The function now dynamically creates appropriate interpolation options based on the selected type.Updated the function documentation to be more comprehensive, explaining the purpose and behavior of each parameter in detail. Removed the test_QA directory and updated dependencies to use the latest versions of gempy_engine (~2025.1.1) and gempy_viewer (~2025.1.0).
Modified the marching cubes test to use the new dense grid options initialization method instead of manually configuring interpolation options.
Relates to #interpolation-options-enhancement
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).