Switch to SASL subprotocol on AUTH command #277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Python's SMTPLIB sends all verbs in lowercase and gen_smtp fails to recognize
rset\r\n
command.UPD: while digging deeper, I found https://datatracker.ietf.org/doc/html/rfc4954 and it says that
AUTH xxxx
verb actually makes client/server switch to a SASL subprotocol which uses base64-encoded data exchange. So, it does not make sense to use the samehandle_request
/parse_request
functions as the ones we use for regular SMTP.RFC also says that client may interrupt SASL subprotocol by sending
*\r\n
, but I'm not implementing this feature here.