Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use OTP logger directly; drop hut dependency #309

Merged
merged 3 commits into from
Feb 12, 2022

Conversation

seriyps
Copy link
Collaborator

@seriyps seriyps commented Feb 12, 2022

Since we are already OTP-21+, there is no real reason to rely on hut for logger abstraction.

It replaces #267 since other PR seems stuck.

This PR also adds domain metadata to each log gen_smtp generates so it's easier to filter logs generated by gen_smtp using logger_filters:domain.

Most of the changes were made by just running sed commands like this: sed -i 's/\?log(warning, /\?LOG_WARNING(/' src/*.erl

@seriyps seriyps mentioned this pull request Feb 12, 2022
Copy link
Contributor

@cw789 cw789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked the diff. Looks good as far as I could say.
Thanks. 💛

@seriyps seriyps requested a review from mworrell February 12, 2022 18:32
Copy link
Collaborator

@mworrell mworrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to use OTP logger directly.

This is good for now, we can change to more structured logging at some later time.

@mworrell mworrell merged commit 197e7ea into gen-smtp:master Feb 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants